feat(taro): 改进事件处理函数不存在时的错误提示, close NervJS#2600

vimcaw · Mar 27, 2019 · a820fb9 · a820fb9
1 parent 2a8224e
commit a820fb9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/packages/taro-alipay/src/create-component.js b/packages/taro-alipay/src/create-component.js
@@ -127,7 +127,11 @@ function processEvent (eventHandlerName, obj) {
       }
       realArgs = [...datasetArgs, event]
     }
-    return scope[eventHandlerName].apply(callScope, realArgs)
+    if (scope[eventHandlerName]) {
+      return scope[eventHandlerName].apply(callScope, realArgs)
+    } else {
+      throw `事件处理函数${eventHandlerName}不存在`
+    }
   }
 }
 

diff --git a/packages/taro-swan/src/create-component.js b/packages/taro-swan/src/create-component.js
@@ -144,7 +144,11 @@ function processEvent (eventHandlerName, obj) {
       }
       realArgs = [_scope, ...datasetArgs, ...detailArgs, event]
     }
-    return scope[eventHandlerName].apply(callScope, realArgs)
+    if (scope[eventHandlerName]) {
+      return scope[eventHandlerName].apply(callScope, realArgs)
+    } else {
+      throw `事件处理函数${eventHandlerName}不存在`
+    }
   }
 }
 

diff --git a/packages/taro-tt/src/create-component.js b/packages/taro-tt/src/create-component.js
@@ -147,7 +147,11 @@ function processEvent (eventHandlerName, obj) {
       }
       realArgs = [_scope, ...datasetArgs, ...detailArgs, event]
     }
-    return scope[eventHandlerName].apply(callScope, realArgs)
+    if (scope[eventHandlerName]) {
+      return scope[eventHandlerName].apply(callScope, realArgs)
+    } else {
+      throw `事件处理函数${eventHandlerName}不存在`
+    }
   }
 }
 

diff --git a/packages/taro-weapp/src/create-component.js b/packages/taro-weapp/src/create-component.js
@@ -176,7 +176,11 @@ function processEvent (eventHandlerName, obj) {
       }
       realArgs = [_scope, ...datasetArgs, ...detailArgs, event]
     }
-    return scope[eventHandlerName].apply(callScope, realArgs)
+    if (scope[eventHandlerName]) {
+      return scope[eventHandlerName].apply(callScope, realArgs)
+    } else {
+      throw `事件处理函数${eventHandlerName}不存在`
+    }
   }
 }