Undefined index warnings and notices in ClosureAnalyzer

[mertvetsky]

https://psalm.dev/r/c6cc4713ae

<br />
<b>Notice</b>:  Undefined index: $b in <b>/var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ClosureAnalyzer.php</b> on line <b>137</b><br />
<br />
<b>Notice</b>:  Trying to get property 'parent_nodes' of non-object in <b>/var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ClosureAnalyzer.php</b> on line <b>137</b><br />
<br />
<b>Warning</b>:  Invalid argument supplied for foreach() in <b>/var/www/vhosts/psalm.dev/httpdocs/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/ClosureAnalyzer.php</b> on line <b>139</b><br />

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/c6cc4713ae

<?php
if (rand(0, 1)) {
    $b = 321;
}
$a = function () use ($b):int  {
    return $b;
};
echo $a();

Psalm output (using commit e93e532):

INFO: PossiblyUndefinedVariable - 5:23 - Possibly undefined variable $b, first seen on line 3

INFO: MixedReturnStatement - 6:12 - Could not infer a return type

INFO: MixedInferredReturnType - 5:27 - Could not verify return type 'int' for /var/www/vhosts/psalm.dev/httpdocs/src/somefile.php:5:45:-:closure

INFO: UnusedVariable - 3:5 - $b is never referenced or the value is not used

[weirdan]

@muglug how do you feel about introducing an error handler to convert all notices/warnings/etc into exceptions?

[muglug]

how do you feel about introducing an error handler to convert all notices/warnings/etc into exceptions?

I think that's a great idea! Normally a notice pre-empts a fatal error anyway.