Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: appimage desktop files missing Exec params #152

Closed
gobonja opened this issue Dec 5, 2020 · 4 comments
Closed

Bug: appimage desktop files missing Exec params #152

gobonja opened this issue Dec 5, 2020 · 4 comments
Labels
appimage bug Something isn't working done staging

Comments

@gobonja
Copy link

gobonja commented Dec 5, 2020

Exec params like fiedcodes (%f or %u), --new-window etc are removed when parsing Exec value in desktop file.

This results in problems like opening external links in firefox.

Instead of replacing whole text with easiest solution might be to take text from Exec= to the first blank space and replace it with appimage path.

Best regards

@vinifmor
Copy link
Owner

vinifmor commented Dec 5, 2020

I'm going to have a look here. Thanks for sharing this issue.

Best regards

@vinifmor
Copy link
Owner

vinifmor commented Dec 8, 2020

@gobonja , I've just published the fix to the staging branch. Could you give me a feedback if it is working ? It is available on AUR as bauh-staging (0.9.10.RC-2)

@vinifmor vinifmor added bug Something isn't working and removed enhancement New feature or request labels Dec 8, 2020
@gobonja
Copy link
Author

gobonja commented Dec 8, 2020

@vinifmor I can confirm that it is working in bauh-staging (0.9.10.RC-2)

Great work as always!

@vinifmor
Copy link
Owner

vinifmor commented Dec 9, 2020

Great! Thanks for the feedback @gobonja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appimage bug Something isn't working done staging
Projects
None yet
Development

No branches or pull requests

2 participants