From d13c2a19f3e849350dca1992069751bd075cec93 Mon Sep 17 00:00:00 2001
From: Davidson Souza <me@dlsouza.lol>
Date: Mon, 8 Apr 2024 16:01:34 -0300
Subject: [PATCH] fix some clippy warnings

---
 crates/floresta-cli/src/rpc.rs                |  4 +-
 .../src/p2p_wire/chain_selector.rs            | 38 ++++++++-----------
 2 files changed, 18 insertions(+), 24 deletions(-)

diff --git a/crates/floresta-cli/src/rpc.rs b/crates/floresta-cli/src/rpc.rs
index c0b0377b..d4d50526 100644
--- a/crates/floresta-cli/src/rpc.rs
+++ b/crates/floresta-cli/src/rpc.rs
@@ -114,9 +114,9 @@ pub trait JsonRPCClient: Sized {
     /// Calls a method on the client
     ///
     /// This should call the appropriated rpc method and return a parsed response or error.
-    fn call<T: serde::de::DeserializeOwned>(&self, method: &str, params: &[Value]) -> Result<T>
+    fn call<T>(&self, method: &str, params: &[Value]) -> Result<T>
     where
-        T: for<'a> serde::de::Deserialize<'a> + Debug;
+        T: for<'a> serde::de::Deserialize<'a> + serde::de::DeserializeOwned + Debug;
 }
 
 impl<T: JsonRPCClient> FlorestaRPC for T {
diff --git a/crates/floresta-wire/src/p2p_wire/chain_selector.rs b/crates/floresta-wire/src/p2p_wire/chain_selector.rs
index 7ebd1ed5..97f24542 100644
--- a/crates/floresta-wire/src/p2p_wire/chain_selector.rs
+++ b/crates/floresta-wire/src/p2p_wire/chain_selector.rs
@@ -209,17 +209,13 @@ where
         let mut peer2_version = None;
         for _ in 0..2 {
             if let Ok(Ok(message)) = timeout(Duration::from_secs(60), self.node_rx.recv()).await {
-                match message {
-                    NodeNotification::FromPeer(peer, message) => match message {
-                        PeerMessages::UtreexoState(state) => {
-                            if peer == peer1 {
-                                peer1_version = Some(state);
-                            } else if peer == peer2 {
-                                peer2_version = Some(state);
-                            }
-                        }
-                        _ => {}
-                    },
+                if let NodeNotification::FromPeer(peer, PeerMessages::UtreexoState(state)) = message
+                {
+                    if peer == peer1 {
+                        peer1_version = Some(state);
+                    } else if peer == peer2 {
+                        peer2_version = Some(state);
+                    }
                 }
             }
         }
@@ -411,17 +407,15 @@ where
                 continue;
             }
             let (peer1, peer2) = (peer[0].0, peer[1].0);
-            match self.find_who_is_lying(peer1, peer2).await? {
-                Some(liar) => {
-                    // if we found a liar, we need to ban them
-                    self.send_to_peer(liar, NodeRequest::Shutdown).await?;
-                    if liar == peer1 {
-                        invalid_accs.insert(peer[0].1.clone());
-                    } else {
-                        invalid_accs.insert(peer[1].1.clone());
-                    }
+
+            if let Some(liar) = self.find_who_is_lying(peer1, peer2).await? {
+                // if we found a liar, we need to ban them
+                self.send_to_peer(liar, NodeRequest::Shutdown).await?;
+                if liar == peer1 {
+                    invalid_accs.insert(peer[0].1.clone());
+                } else {
+                    invalid_accs.insert(peer[1].1.clone());
                 }
-                None => {}
             }
         }
         //filter out the invalid accs
@@ -495,7 +489,7 @@ where
             .chain
             .validate_block(&block.block, proof, inputs, del_hashes, acc);
 
-        if !is_valid.is_ok() {
+        if is_valid.is_err() {
             self.chain.switch_chain(other_tip)?;
             self.chain.invalidate_block(fork)?;
         }