Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colorspace issues with gltf/glb format #302

Closed
Aitolda opened this issue Apr 17, 2020 · 5 comments · Fixed by #1181
Closed

colorspace issues with gltf/glb format #302

Aitolda opened this issue Apr 17, 2020 · 5 comments · Fixed by #1181
Labels
bug Something isn't working renderer Touches or changes rendering Severity: Low No important functionality is affected standards-alignment

Comments

@Aitolda
Copy link
Collaborator

Aitolda commented Apr 17, 2020

Gltf color does not translate properly in interface. When compared to an fbx of the same model it will appear slightly darker and less saturated in some cases.

79605032-0b40a800-80a4-11ea-8b6e-a2b4c5bc462e 1

In the example, fbx is on the left, gltf on the right.
fbx
gltf
@Aitolda Aitolda added bug Something isn't working renderer Touches or changes rendering labels Apr 17, 2020
@HifiExperiments HifiExperiments mentioned this issue Jun 30, 2020
Closed
@two-one-five
Copy link
Contributor

This issue has been fixed. :)

@two-one-five
Copy link
Contributor

This issue has not been fixed, I mistook #545 for the solution. :)

Pic from Aitolda:
image

@two-one-five two-one-five reopened this Sep 7, 2020
@ctrlaltdavid
Copy link
Collaborator

Do the colours of those two models look the same in a 3rd party viewer? I tried downloading and viewing them in Windows' built-in 3D Viewer program but only the GLB file is coloured. (The FBX renders as grey scale.) Similarly for Windows' Paint3D program. ... I surmise that the FBX file uses external textures.

@ctrlaltdavid ctrlaltdavid mentioned this issue Jan 9, 2021
Closed
@Aitolda
Copy link
Collaborator Author

Aitolda commented Mar 9, 2021

Revisted. This issues still exist as of Vircadia 2021.1.0 Eos. However we are considering witch to ASSIMP which may solve many of these issues.

@Aitolda Aitolda added the Severity: Low No important functionality is affected label Mar 9, 2021
@SilverfishVR SilverfishVR mentioned this issue Mar 29, 2021
Merged
@ctrlaltdavid
Copy link
Collaborator

The colour test in the following issue should be useful: #957

@ctrlaltdavid ctrlaltdavid mentioned this issue Apr 17, 2021
Merged
@ctrlaltdavid ctrlaltdavid linked a pull request Apr 18, 2021 that will close this issue
Fix glTF mesh colors #1181
Merged
HifiExperiments pushed a commit to HifiExperiments/project-athena that referenced this issue Nov 6, 2023
@JulianGro
Merge pull request vircadia#302 from daleglass-overte/allow-fullscree…
90efffa 
…n-display-selection

Allow fullscreen display selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working renderer Touches or changes rendering Severity: Low No important functionality is affected standards-alignment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix glTF mesh colors ctrlaltdavid/vircadia
4 participants
@ctrlaltdavid @Aitolda @two-one-five @digisomni