Skip to content

Commit

Permalink
change image tag to be for the current PR
Browse files Browse the repository at this point in the history
  • Loading branch information
helayoty committed Aug 29, 2022
1 parent 5b4ac64 commit 3bc7116
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
13 changes: 1 addition & 12 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ jobs:
environment: test
env:
REGISTRY: ${{ needs.export-registry.outputs.registry }}
IMG_VERSION: "dev"
IMG_TAG: "dev"
runs-on: ubuntu-latest
steps:
- name: Set up Go
Expand All @@ -74,20 +72,11 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Set image version
run: |
echo "IMG_VERSION=$(git describe --abbrev=0 --tags --always)" >> $GITHUB_ENV
- name: Set Image tag
run: |
ver=${{ env.IMG_VERSION}}
echo "IMG_TAG=${ver#"v"}" >> $GITHUB_ENV
- name: Build image
run: |
OUTPUT_TYPE=type=registry make docker-build-image
env:
VERSION: ${{ env.IMG_VERSION }}
VERSION: ${{ github.event.number }}

- name: Install Azure CLI latest
run: |
Expand Down
2 changes: 1 addition & 1 deletion hack/e2e/aks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ fi

: "${RANDOM_NUM:=$RANDOM}"
: "${RESOURCE_GROUP:=vk-aci-test-$RANDOM_NUM}"
: "${LOCATION:=eastus2euap}"
: "${LOCATION:=}"
: "${CLUSTER_NAME:=${RESOURCE_GROUP}}"
: "${NODE_COUNT:=1}"
: "${CHART_NAME:=vk-aci-test-aks}"
Expand Down

0 comments on commit 3bc7116

Please sign in to comment.