Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: "enhancement: Upgrade to nodeutil" #269

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

helayoty
Copy link
Member

Reverts #211

@helayoty helayoty requested a review from cpuguy83 August 29, 2022 23:10
@helayoty helayoty temporarily deployed to test August 29, 2022 23:10 Inactive
@helayoty helayoty temporarily deployed to test August 29, 2022 23:11 Inactive
@helayoty helayoty temporarily deployed to test August 29, 2022 23:39 Inactive
@helayoty helayoty temporarily deployed to test August 29, 2022 23:39 Inactive
@helayoty helayoty force-pushed the revert-211-upgrade-to-nodeutil branch from 3bc7116 to f7f7a6d Compare August 29, 2022 23:41
@helayoty helayoty temporarily deployed to test August 29, 2022 23:41 Inactive
@helayoty helayoty temporarily deployed to test August 29, 2022 23:41 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #269 (f7f7a6d) into master (94504e3) will increase coverage by 0.24%.
The diff coverage is 50.98%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   42.67%   42.92%   +0.24%     
==========================================
  Files          35       35              
  Lines        3496     3471      -25     
==========================================
- Hits         1492     1490       -2     
+ Misses       1821     1800      -21     
+ Partials      183      181       -2     
Impacted Files Coverage Δ
provider/podsTracker.go 0.00% <0.00%> (ø)
provider/aci.go 36.41% <39.13%> (+0.13%) ⬆️
provider/config.go 68.29% <100.00%> (ø)
provider/metrics/metrics.go 82.70% <100.00%> (+1.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty force-pushed the revert-211-upgrade-to-nodeutil branch from f7f7a6d to c23ff7b Compare August 30, 2022 16:46
@helayoty helayoty temporarily deployed to test August 30, 2022 16:46 Inactive
@helayoty helayoty temporarily deployed to test August 30, 2022 16:47 Inactive
@helayoty helayoty force-pushed the revert-211-upgrade-to-nodeutil branch from c23ff7b to 7201610 Compare August 30, 2022 16:47
@helayoty helayoty temporarily deployed to test August 30, 2022 16:47 Inactive
@helayoty helayoty force-pushed the revert-211-upgrade-to-nodeutil branch from 7201610 to db1074b Compare August 30, 2022 16:48
@helayoty helayoty temporarily deployed to test August 30, 2022 16:48 Inactive
@helayoty helayoty temporarily deployed to test August 30, 2022 16:48 Inactive
@helayoty helayoty force-pushed the revert-211-upgrade-to-nodeutil branch from db1074b to 245d150 Compare August 30, 2022 16:49
@helayoty helayoty temporarily deployed to test August 30, 2022 16:50 Inactive
@helayoty helayoty temporarily deployed to test August 30, 2022 16:50 Inactive
@helayoty helayoty merged commit 1e03f57 into master Aug 30, 2022
cpuguy83 added a commit to cpuguy83/azure-aci that referenced this pull request Aug 30, 2022
@helayoty helayoty deleted the revert-211-upgrade-to-nodeutil branch August 31, 2022 23:57
helayoty pushed a commit to cpuguy83/azure-aci that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants