chore: Update azure-aci to use nodeutil instead of node-cli #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big diff due to undoing the revert. |
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 42.79% 42.54% -0.25%
==========================================
Files 35 35
Lines 3491 3516 +25
==========================================
+ Hits 1494 1496 +2
- Misses 1816 1837 +21
- Partials 181 183 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
helayoty
reviewed
Sep 1, 2022
| flags.StringVar(&clusterDomain, "cluster-domain", clusterDomain, "kubernetes cluster-domain") | ||
| flag.DurationVar(&startupTimeout, "startup-timeout", startupTimeout, "How long to wait for the virtual-kubelet to start") | ||
| flags.BoolVar(&disableTaint, "disable-taint", disableTaint, "disable the node taint") | ||
| flag.StringVar(&operatingSystem, "os", operatingSystem, "Operating System (Linux/Windows)") |
There was a problem hiding this comment.
Suggested change
| flag.StringVar(&operatingSystem, "os", operatingSystem, "Operating System (Linux/Windows)") | |
| flags.StringVar(&operatingSystem, "os", operatingSystem, "Operating System (Linux/Windows)") |
helayoty
reviewed
Sep 1, 2022
| flags.StringVar(&nodeName, "nodename", nodeName, "kubernetes node name") | ||
| flags.StringVar(&cfgPath, "provider-config", cfgPath, "cloud provider configuration file") | ||
| flags.StringVar(&clusterDomain, "cluster-domain", clusterDomain, "kubernetes cluster-domain") | ||
| flag.DurationVar(&startupTimeout, "startup-timeout", startupTimeout, "How long to wait for the virtual-kubelet to start") |
There was a problem hiding this comment.
Not used anymore and needs to be removed.
…)" This reverts commit 1e03f57.
1. Routes were not setup and causing panics 2. The CA was not being loaded into the webhook auth and as such only token auth was available. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
helayoty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix webhook certificate auth with nodeutil
token auth was available.