Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix init image tag version #472

Merged
merged 2 commits into from
Feb 28, 2023
Merged

fix: Fix init image tag version #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75aef4b
Fix init image tag version
helayoty Feb 27, 2023
5f5a264
Merge branch 'master' into fix-init-tag-helm
helayoty Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/virtual-kubelet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ The following table lists the configurable parameters of the azure-aci chart and
| image.tag | Image release version/tag. | `latest` |
| image.pullPolicy | Image pull policy. | `Always` |
| initImage.name | Init container image name. | `oss/virtual-kubelet/init-validation` |
| initImage.tag | Init container image release version/tag. | `0.1.0` |
| initImage.initTag | Init container image release version/tag. | `0.1.0` |
| initImage.pullPolicy | Init container image pull policy. | `Always` |
| nodeName | The node name that will be assigned to be the VK one. | `virtual-node-aci-linux-helm` |
| nodeOsType | The node/VM type. Values should be `Windows` or `Linux`. | `Linux` |
Expand Down
2 changes: 1 addition & 1 deletion charts/virtual-kubelet/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
{{- if .Values.useVKVersion2 }}
initContainers:
- name: init-validation
image: "{{ .Values.initImage.repository }}/{{ .Values.initImage.name }}:{{ .Values.initImage.tag }}"
image: "{{ .Values.initImage.repository }}/{{ .Values.initImage.name }}:{{ .Values.initImage.initTag }}"
imagePullPolicy: {{ .Values.initImage.pullPolicy }}
env:
- name: USE_VK_VERSION_2
Expand Down
2 changes: 1 addition & 1 deletion charts/virtual-kubelet/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ image:
initImage:
repository: mcr.microsoft.com
name: oss/virtual-kubelet/init-validation
tag: 1.5.0
initTag: 0.1.0
pullPolicy: Always

namespace: vk-azure-aci
Expand Down