Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provider metrics resource update #481

Merged
merged 15 commits into from
Apr 26, 2023
Merged

feat: provider metrics resource update #481

merged 15 commits into from
Apr 26, 2023

Conversation

fnuarnav
Copy link
Collaborator

@fnuarnav fnuarnav commented Mar 7, 2023 •
edited by helayoty
Loading

GetMetricsResource converts the output of GetStatsSummary and serves the metrics using Prometheus MetricFamily.

Implements virtual-kubelet/virtual-kubelet#1101

@fnuarnav fnuarnav temporarily deployed to test March 7, 2023 18:57 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test March 7, 2023 18:58 — with GitHub Actions Inactive
@fnuarnav fnuarnav changed the title Fnuarnav/provider metrics resource update feat: fnuarnav/provider metrics resource update Mar 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023 •
edited by codecov bot
Loading

Codecov Report

Merging #481 (2418ae2) into master (c6fd9af) will increase coverage by 0.53%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   67.45%   67.99%   +0.53%     
==========================================
  Files          15       15              
  Lines        2486     2506      +20     
==========================================
+ Hits         1677     1704      +27     
+ Misses        693      688       -5     
+ Partials      116      114       -2
Impacted Files Coverage Δ
pkg/provider/aci.go 67.25% <0.00%> (-0.15%) ⬇️
pkg/metrics/metrics.go 84.31% <77.77%> (+8.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fnuarnav fnuarnav temporarily deployed to test March 7, 2023 20:20 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test March 7, 2023 20:20 — with GitHub Actions Inactive
@helayoty
Copy link
Member

virtual-kubelet/virtual-kubelet#1082

@fnuarnav fnuarnav temporarily deployed to test March 22, 2023 20:09 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 22, 2023 22:25 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 22, 2023 22:25 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test March 23, 2023 19:40 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test March 23, 2023 19:40 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 20, 2023 05:03 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 20, 2023 05:03 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 20, 2023 05:16 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 20, 2023 05:16 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 20, 2023 06:09 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 26, 2023 20:14 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 26, 2023 20:14 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 26, 2023 20:28 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 26, 2023 20:29 — with GitHub Actions Inactive
@helayoty helayoty enabled auto-merge (squash) April 26, 2023 20:48
@helayoty helayoty changed the title feat: fnuarnav/provider metrics resource update feat: provider metrics resource update Apr 26, 2023
@fnuarnav fnuarnav temporarily deployed to test April 26, 2023 21:10 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test April 26, 2023 21:17 — with GitHub Actions Inactive
@helayoty helayoty merged commit 2382511 into virtual-kubelet:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helayoty helayoty helayoty approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fnuarnav @codecov-commenter @helayoty