Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added unit test for deleteContainerGroup #506

Merged
merged 5 commits into from
Mar 30, 2023

Conversation

smritidahal653
Copy link
Collaborator

Added unit test for deleteContaierGroup in aci.go. This will also test updatePodStatus method in podsTracker.go by attaching a podTracker object to the test provider.

@smritidahal653 smritidahal653 temporarily deployed to test March 29, 2023 21:00 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 29, 2023 21:00 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #506 (cf4d203) into master (1385500) will increase coverage by 0.89%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
+ Coverage   49.73%   50.63%   +0.89%     
==========================================
  Files          14       14              
  Lines        2455     2455              
==========================================
+ Hits         1221     1243      +22     
+ Misses       1147     1123      -24     
- Partials       87       89       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smritidahal653 smritidahal653 temporarily deployed to test March 29, 2023 21:17 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 29, 2023 21:17 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 29, 2023 23:27 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 29, 2023 23:27 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 30, 2023 00:13 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 30, 2023 00:13 — with GitHub Actions Inactive
@helayoty helayoty merged commit 0bc8184 into virtual-kubelet:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants