Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Unit Test for GetContainerLogs #522

Merged
merged 4 commits into from
Apr 10, 2023
Merged

test: Unit Test for GetContainerLogs #522

merged 4 commits into from
Apr 10, 2023

Conversation

nidhunge
Copy link
Contributor

@nidhunge nidhunge commented Apr 7, 2023

Issue Link: #504

  • Converted v1 to corev1 for import package per convention.

@nidhunge nidhunge temporarily deployed to test April 7, 2023 02:00 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 7, 2023 02:00 — with GitHub Actions Inactive
@nidhunge nidhunge mentioned this pull request Apr 7, 2023
Closed
8 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #522 (b8b675b) into master (6a71dd9) will increase coverage by 0.48%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   59.94%   60.42%   +0.48%     
==========================================
  Files          14       14              
  Lines        2469     2469              
==========================================
+ Hits         1480     1492      +12     
+ Misses        880      866      -14     
- Partials      109      111       +2

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Fei-Guo
Fei-Guo reviewed Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

helayoty
helayoty reviewed Apr 7, 2023
View reviewed changes
pkg/provider/aci_test.go Outdated Show resolved Hide resolved
helayoty
helayoty approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise LGTM.

@nidhunge nidhunge temporarily deployed to test April 10, 2023 16:21 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 10, 2023 16:21 — with GitHub Actions Inactive
@helayoty helayoty changed the title test: Unit Test for pkg/provider/aci.go/GetContainerLogs test: Unit Test for GetContainerLogs Apr 10, 2023
@helayoty helayoty enabled auto-merge (squash) April 10, 2023 16:33
@helayoty helayoty merged commit fa3fe8b into virtual-kubelet:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo left review comments

@helayoty helayoty helayoty approved these changes

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nidhunge @codecov-commenter @helayoty @Fei-Guo