Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add network testing mocks #527

Merged
merged 2 commits into from
Apr 11, 2023
Merged

test: Add network testing mocks #527

merged 2 commits into from
Apr 11, 2023

Conversation

helayoty
Copy link
Member

To be able to write unit tests for the aci_network package, we need to mock the networking client along with create/get APIs.

In order to achieve that, we introduce a new interface, ProviderNetworkInterface that will implement:

  • getSubnetClient
  • getACISubnet
  • getACISubnet

Note: A separate commit has been added for missing copyright headers in some files.

@helayoty helayoty requested a review from Fei-Guo as a code owner April 11, 2023 18:24
@helayoty helayoty temporarily deployed to test April 11, 2023 18:24 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 11, 2023 18:24 — with GitHub Actions Inactive
@helayoty
Add missing copyright header
c7c4acc 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test April 11, 2023 18:28 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 11, 2023 18:28 — with GitHub Actions Inactive
@helayoty
Add networking mock
8130391 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test April 11, 2023 18:32 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 11, 2023 18:32 — with GitHub Actions Inactive
nidhunge
nidhunge reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@nidhunge nidhunge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@Fei-Guo Fei-Guo merged commit 7e523b0 into virtual-kubelet:master Apr 11, 2023
@helayoty helayoty deleted the networking-ut branch April 11, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhunge nidhunge nidhunge left review comments

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helayoty @Fei-Guo @nidhunge