Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update network methods for unit test #532

Merged
merged 1 commit into from
Apr 13, 2023
Merged

refactor: Update network methods for unit test #532

merged 1 commit into from
Apr 13, 2023

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Apr 12, 2023 •
edited
Loading

  • Update network SetVNETConfig and setupNetwork methods to be able to test them.

  • Remove mock as it will be complex to embed the interface.

@helayoty helayoty requested a review from Fei-Guo as a code owner April 12, 2023 23:35
@helayoty helayoty temporarily deployed to test April 12, 2023 23:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 12, 2023 23:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 12, 2023 23:56 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 12, 2023 23:56 — with GitHub Actions Inactive
@smritidahal653
Copy link
Collaborator

LGTM

@helayoty helayoty temporarily deployed to test April 13, 2023 00:31 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 00:31 — with GitHub Actions Inactive
@helayoty helayoty mentioned this pull request Apr 13, 2023
Closed
3 tasks
@helayoty helayoty temporarily deployed to test April 13, 2023 02:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 02:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 03:30 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 17:49 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 17:49 — with GitHub Actions Inactive
@helayoty
Pass ProviderNetworkInterface to methods to be able to mock them
6c9694c 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test April 13, 2023 18:43 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test April 13, 2023 18:43 — with GitHub Actions Inactive
@helayoty helayoty changed the title test: Pass ProviderNetworkInterface to methods to be able to mock refactor: Update network methods for unit test Apr 13, 2023
@helayoty helayoty enabled auto-merge (squash) April 13, 2023 19:01
@helayoty helayoty merged commit 4856775 into virtual-kubelet:master Apr 13, 2023
@helayoty helayoty deleted the pass-interface branch April 13, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees
No one assigned
Labels
kind/refactor kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helayoty @smritidahal653 @Fei-Guo