Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container state. #547

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

hypnoce
Copy link
Contributor

@hypnoce hypnoce commented May 23, 2023

started is always true. make pod with startup probe fail.
ensure terminated container group report a terminated state in k8s.

@hypnoce hypnoce temporarily deployed to test May 23, 2023 15:30 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #547 (9aa23ae) into master (a2d398f) will increase coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   68.48%   68.95%   +0.47%     
==========================================
  Files          15       15              
  Lines        2573     2583      +10     
==========================================
+ Hits         1762     1781      +19     
+ Misses        695      686       -9     
  Partials      116      116              
Impacted Files Coverage Δ
pkg/provider/aci.go 68.36% <100.00%> (+0.23%) ⬆️
pkg/provider/containergroup_to_pod.go 78.39% <100.00%> (+4.92%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

started is always true. make pod with startup probe fail.
ensure terminated container group report a terminated state in k8s.
@hypnoce hypnoce temporarily deployed to test June 5, 2023 16:55 — with GitHub Actions Inactive
@hypnoce hypnoce temporarily deployed to test June 5, 2023 16:55 — with GitHub Actions Inactive
@helayoty helayoty merged commit 0f59ade into virtual-kubelet:master Jun 5, 2023
@helayoty helayoty added this to the 1.6.0 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants