Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 579 and error handling when aci provider fail to be initialized #582

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

smritidahal653
Copy link
Collaborator

@smritidahal653 smritidahal653 commented Nov 28, 2023

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (749ae82) 69.81% compared to head (d26cb15) 69.81%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   69.81%   69.81%           
=======================================
  Files          15       15           
  Lines        2597     2597           
=======================================
  Hits         1813     1813           
  Misses        666      666           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helayoty helayoty linked an issue Nov 28, 2023 that may be closed by this pull request
@Fei-Guo Fei-Guo merged commit bb38fd5 into virtual-kubelet:master Nov 28, 2023
7 checks passed
@smritidahal653 smritidahal653 deleted the smriti_bugfix branch December 11, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate app label causes helm install failure
2 participants