Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfixes and release condition update #634

Merged
merged 9 commits into from
Aug 13, 2024
Merged

Conversation

smritidahal653
Copy link
Collaborator

@smritidahal653 smritidahal653 commented Aug 8, 2024

  • Subnet PUT findings for addressPrefix vs addressPrefixes usage:
    • If neither is included in the payload, the request will return an error with code "AddressPrefixStringCannotBeNullOrEmpty"
    • If we send in payload with addressPrefix, resource will have properties.addressPrefix populated
    • If we send in payload with addressPrefixes, resource will have properties.addressPrefixes populated
    • If we send in payload with both addressPrefix and addressPrefixes, resource will have properties.addressPrefix populated (even if addressPrefix and addressPrefixes have two different values)
  • Changes to aci_network.go: updated CreateOrUpdateACISubnet function so it takes the currentSubnet as a parameter and checks whether its a subnet create vs update flow based on it (moved this logic out of setupNetwork function to keep it simple). We only set the AddressPrefix on create and ACI service delegation is added to the payload in both create and update scenarios.
  • fixing init validation container test to use the vk pod as aci-connector-linux pod is only created on --enable-addon flow
  • fixing workflow triggers to match current release branch naming convention

Signed-off-by: Smriti Dahal <93288516+smritidahal653@users.noreply.github.com>
@smritidahal653 smritidahal653 changed the title fix : Update e2e-tests.yml fix: Update e2e-tests.yml Aug 9, 2024
@smritidahal653 smritidahal653 changed the title fix: Update e2e-tests.yml fix: bugfixes and release condition update Aug 9, 2024
@smritidahal653 smritidahal653 marked this pull request as ready for review August 9, 2024 22:14
@smritidahal653 smritidahal653 merged commit a605ab5 into master Aug 13, 2024
4 checks passed
@smritidahal653 smritidahal653 deleted the sdahal/e2e_test branch August 13, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants