-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bugfixes and release condition update #634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smritidahal653
commented
Aug 8, 2024
•
edited
Loading
edited
- Subnet PUT findings for addressPrefix vs addressPrefixes usage:
- If neither is included in the payload, the request will return an error with code "AddressPrefixStringCannotBeNullOrEmpty"
- If we send in payload with addressPrefix, resource will have properties.addressPrefix populated
- If we send in payload with addressPrefixes, resource will have properties.addressPrefixes populated
- If we send in payload with both addressPrefix and addressPrefixes, resource will have properties.addressPrefix populated (even if addressPrefix and addressPrefixes have two different values)
- Changes to aci_network.go: updated CreateOrUpdateACISubnet function so it takes the currentSubnet as a parameter and checks whether its a subnet create vs update flow based on it (moved this logic out of setupNetwork function to keep it simple). We only set the AddressPrefix on create and ACI service delegation is added to the payload in both create and update scenarios.
- fixing init validation container test to use the vk pod as aci-connector-linux pod is only created on --enable-addon flow
- fixing workflow triggers to match current release branch naming convention
Signed-off-by: Smriti Dahal <93288516+smritidahal653@users.noreply.github.com>
smritidahal653
changed the title
fix: Update e2e-tests.yml
fix: bugfixes and release condition update
Aug 9, 2024
helayoty
reviewed
Aug 10, 2024
Fei-Guo
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.