-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log support requires CGO #84
Comments
|
it does run on debian stable |
miekg
changed the title
Builds pulls in clibs, no longer statically linked
log support requires CGO
Feb 2, 2021
ok, the dyn. linked binary runs on RH8 - which is good. I'm still going to add the PR to remove this all together, but it seems this usable at this point |
miekg
added a commit
that referenced
this issue
Feb 4, 2021
This removes the CGO deps and makes for a completely static Go binary. The downside is that is fork/execs a binary to get to the logs. It supports the same options as the current impl. A thing that's different is the time/date output which doesn't match up. No real intentation to get this merged (current binary runs on RH8 which I care about atm), but also don't want to loose the code as there were some tricky bits about tailing the logs and not creating zombie journalctls. See #84 Signed-off-by: Miek Gieben <miek@miek.nl>
For reference, the code as is in main has been validated by me in RHEL7, RHEL8 and Ubuntu 20.04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#70 and #69 add log support, but it calls a clib, so now we no longer create a static build, but ref libc and friends
This also makes a releasing a no go, because I will probably have an incompatible libc.
This creates a static bin on my setup.
Another downside of cgo is that per go routines stack is no longer 2k, it's 1M or something
The text was updated successfully, but these errors were encountered: