From 99a4eb4f8a532c125bed292c6e1d505f78101fee Mon Sep 17 00:00:00 2001 From: Ichidai TACHIBANA <> Date: Fri, 3 Sep 2021 14:59:37 +0900 Subject: [PATCH] Drop sublayers with no data even if the _subLayerProps prop contains --- docs/api-reference/core/composite-layer.md | 2 +- modules/core/src/lib/composite-layer.js | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/api-reference/core/composite-layer.md b/docs/api-reference/core/composite-layer.md index 2fe7ecec269..8b8d0716d5a 100644 --- a/docs/api-reference/core/composite-layer.md +++ b/docs/api-reference/core/composite-layer.md @@ -270,7 +270,7 @@ Parameters: * `id` (String) - the sublayer id * `data` (Array) - the sublayer data -Returns `true` if the sublayer should be rendered. The base class implementation returns `true` if either `data` is not empty or the `_subLayerProps` prop contains override for this sublayer. +Returns `true` if the sublayer should be rendered. The base class implementation returns `true` if `data` is not empty. ##### `getSubLayerClass` diff --git a/modules/core/src/lib/composite-layer.js b/modules/core/src/lib/composite-layer.js index 03df7fa732f..78e2cd6b99e 100644 --- a/modules/core/src/lib/composite-layer.js +++ b/modules/core/src/lib/composite-layer.js @@ -90,9 +90,7 @@ export default class CompositeLayer extends Layer { // Returns true if sub layer needs to be rendered shouldRenderSubLayer(id, data) { - const {_subLayerProps: overridingProps} = this.props; - - return (data && data.length) || (overridingProps && overridingProps[id]); + return data && data.length; } // Returns sub layer class for a specific sublayer