Merge branch 'master' into dsavinov/tile-converter-docs

.eslintrc.cjs

@@ -30,7 +30,9 @@ const config = getESLintConfig({
       'default-case': ['warn'],
       'no-eq-null': ['warn'],
       eqeqeq: ['warn'],
-      radix: 0
+      radix: 0,
+      'no-use-before-define': 0,
+      'no-shadow': ['warn']
       // 'accessor-pairs': ['error', {getWithoutSet: false, setWithoutGet: false}]
     },
 
@@ -50,7 +52,10 @@ const config = getESLintConfig({
           '@typescript-eslint/no-non-null-assertion': 0,
           '@typescript-eslint/no-non-null-asserted-optional-chain': 0,
           '@typescript-eslint/no-floating-promises': 0,
+
           // Gradually enable
+          'no-shadow': 0,
+          '@typescript-eslint/no-explicit-any': 0,
           '@typescript-eslint/ban-ts-comment': 0,
           '@typescript-eslint/ban-types': 0,
           '@typescript-eslint/no-unsafe-member-access': 0,

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -0,0 +1,76 @@
+name: Bug Report
+description: Something does not work as expected
+title: "[Bug]"
+labels: bug
+body:
+- type: markdown
+  attributes:
+    value: |
+      Thank you for taking the time to report a bug!
+- type: markdown
+  attributes:
+    value: |
+      **Note: In order to prevent drowning in unactionable issues, any issues that are not clearly actionable will be closed immediately.** 
+      In particular, if you are having issues with your particular build environment that are not clearly root caused,
+      please start a conversation in [Discussions](https://github.com/visgl/loaders.gl/discussions) rather than opening issues.
+      Also please start new feature proposals in the Discussions section.
+- type: markdown
+  attributes:
+    value: |
+      "loaders.gl" is maintained by a few individuals but we can only cover so much.
+      We partly rely on the people who report bugs to make PRs for the fixes.
+      If you choose to open PRs, the vis.gl / Open Visualization leads are focused on helping review and land your PRs, and publish new versions with your fixes.
+      Simple fixes will generally land quickly if you are willing to address comments and fix linter issues.
+- type: markdown
+  attributes:
+    value: |
+      Tips: Before filing a new bug:
+      Check [existing issues](https://github.com/visgl/loaders.gl/issues)to avoid filing duplicate bugs.
+      You may find answers faster by searching in [the documentation](https://loaders.gl/search).
+- type: textarea
+  id: flavor
+  attributes:
+    label: Loader
+    description: First, we need to understand which loader you are using.
+- type: textarea
+  attributes:
+    label: Description
+    description: What you're experiencing.
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Expected Behavior
+    description: What you expect to see.
+  validations:
+    required: false
+- type: textarea
+  attributes:
+    label: Steps to Reproduce
+    description: |
+      Providing the following could help us resolve this issue faster:
+        - A Codepen that reproduces the behavior. A good starting point is the "edit in CodePen" links in the layer documentations.
+        - A sample of your dataset
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Environment
+    description: |
+      Example:
+        - **Framework version**: loaders.gl@4.2.0
+        - **Browser**: Chrome 110.0
+        - **Node**: Node 20.0
+    value: |
+        - Framework version:
+        - Browser:
+        - Node:
+        - OS:
+  validations:
+    required: true
+- type: textarea
+  attributes:
+    label: Logs
+    description: Check the browser or node console for any relevant errors or warnings.
+  validations:
+    required: false

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: false
+contact_links:
+  - name: I have a question / I need help
+    url: https://github.com/visgl/loaders.gl/discussions
+    about: Please ask generic questions or request help in discussions. Non-specific issues will be closed by maintainers.

.github/workflows/test.yml

@@ -39,10 +39,9 @@ jobs:
 
       - name: Build website
         run: |
-          cd website ; yarn install ; yarn run build
+          cd website; yarn build
   
       - name: Coveralls
-        if: matrix.node-version == 18
         uses: coverallsapp/github-action@master
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -27,7 +27,7 @@ package-lock.json
 !.yarn/sdks
 !.yarn/versions
 
-tsconfig.tsbuildinfo
+*.tsbuildinfo
 
 .nyc_output/
 coverage/

.ocularrc.js

@@ -12,8 +12,8 @@ const config = {
   babel: false,
 
   lint: {
-    paths: ['modules', 'dev-docs', 'docs'], // , 'test', 'examples'],
-    extensions: ['js', 'ts']
+    paths: ['modules', 'dev-docs', 'docs', 'test'], //, 'examples'],
+    extensions: ['js', 'jsx', 'cjs', 'mjs', 'ts', 'tsx', 'md'] // , 'mdx'],
     // extensions: ['js', 'jsx', 'mjs', 'ts', 'tsx', 'md']
   },
 

CHANGELOG.md

@@ -2,6 +2,19 @@
 
 ## v4.3
 
+### v4.3.0-beta.1
+
+- feat(gltf): extensions, encoding feature metadata (#2972)
+
+### v4.3.0-alpha.8
+
+- fix(3d-tiles): Rewrite of parseImplicitTiles for readability (#3086)
+- feat(converter): support writing 3DTILES of version 1.1 (#3054)
+- chore: bump ocular-dev-tools (#3075)
+- feat(gltf): ext-structural-metadata encoding (#3080)
+- chore(examples): bump @deck.gl version (#3081)
+- chore: Bump to math.gl@4.1.0 (#3082)
+
 ### v4.3.0-alpha.7
 
 - fix(tile-converter): Fix according to new NodeJS security limitations (#3071)
@@ -136,7 +149,7 @@
 - website: new hero example (#2907)
 - chore(lerc): Restore lerc module (#2912)
 - fix(parquet): Restore ParquetWASMLoader after esbuild upgrade (#2915)
-- fix(*): Fix transitive internal dependencies (#2919)
+- fix(\*): Fix transitive internal dependencies (#2919)
 - fix(parquet): Zstd-codec import turned on (#2922)
 - chore(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /website (#2926)
 - chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 in /website (#2920)
@@ -154,7 +167,7 @@
 ### v4.2.0-alpha.5
 
 - chore: Upgrade ocular-dev-tools to tsc+esbuild (#2897)
-- fix(core): Avoid reassigning loaders._state (#2905)
+- fix(core): Avoid reassigning loaders.\_state (#2905)
 - feat(loader-utils): Add RequestScheduler 'debounceTime' option (#2892)
 - chore: Port I3S examples to v9 (#2903)
 - chore: Move examples to deck.gl@9.0.0-beta.5 (#2901)
@@ -260,7 +273,7 @@
 - chore: ensure all Writers have an encode() method (#2826)
 - feat(zip): Added append and truncate functionality (#2800)
 - fix(crypto): crc32 algorithm fix (#2819)
-- fix(crypto):  Reuse of Hash instance failures (#2824)
+- fix(crypto): Reuse of Hash instance failures (#2824)
 
 ### v4.1.0-alpha.2
 
@@ -290,6 +303,7 @@
 ## v4.0
 
 ### v4.0.4
+
 - feat(arrow): GeoArrowLoader (#2796)
 - fix(draco): revert --format=esm for the worker (#2795)
 - feat(arrow): Support GeoJSON output from Geo ArrowLoader (#2794)
@@ -486,7 +500,7 @@
 - chore: Add loader type parameters (#2626)
 - feat(tile-converter): support EXT_mesh_features and EXT_structural_metadata (#2566)
 - feat(core): non-specific parse functions return unknown (#2625)
-- chore(csv): Ensure tests  use typed CSVLoader (#2621)
+- chore(csv): Ensure tests use typed CSVLoader (#2621)
 - docs(core): Typed loaders (#2624)
 - chore(zip): Remove zip module dependency on @loaders.gl/core (#2622)
 - chore: Clean up module imports, remove default exports in images module (#2617) (#2623)

CODE_OF_CONDUCT.md

@@ -1,3 +1,3 @@
 # Code of Conduct
 
-loaders.gl is an [OpenJS Foundation](https://openjsf.org/) project. Please be mindful of and adhere to the OpenJS Foundation's [Code of Conduct](https://github.com/openjs-foundation/cross-project-council/blob/main/CODE_OF_CONDUCT.md) when contributing to loaders.gl.
+loaders.gl is an [OpenJS Foundation](https://openjsf.org/) project. Please be mindful of and adhere to the OpenJS Foundation's [Code of Conduct](https://github.com/openjs-foundation/cross-project-council/blob/main/CODE_OF_CONDUCT.md) when contributing to loaders.gl.

CONTRIBUTING.md

@@ -35,4 +35,3 @@ If you are interested in becoming a maintainer, read the [governance guidelines]
 
 The vis.gl TSC meets monthly and publishes meeting notes via a [mailing list](https://lists.uc.foundation/g/visgl).
 This mailing list can also be utilized to reach out to the TSC.
-

README.md

@@ -14,7 +14,7 @@
 
 loaders.gl is extensively documented on the [loaders.gl](https://loaders.gl) website.
 
-## Contributing 
+## Contributing
 
 See [CONTRIBUTING.md](CONTRIBUTING.md).
 

dev-docs/RFCs/3d-tiles-and-i3s.md

@@ -24,7 +24,7 @@ geometry file / texture file / feature file (optional)
 
 |                   | 3D Tiles                                                                                                              | I3S                                                                                                                       |
 | ----------------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------- |
-| tileset file      | [tileset.json](https://assets.ion.cesium.com/43978/tileset.json) (token is required)                                      | [i3s layer](https://tiles.arcgis.com/tiles/z2tnIkrLQ2BRzr6P/arcgis/rest/services/SanFrancisco_Bldgs/SceneServer/layers/0) |
+| tileset file      | [tileset.json](https://assets.ion.cesium.com/43978/tileset.json) (token is required)                                  | [i3s layer](https://tiles.arcgis.com/tiles/z2tnIkrLQ2BRzr6P/arcgis/rest/services/SanFrancisco_Bldgs/SceneServer/layers/0) |
 |                   |                                                                                                                       |                                                                                                                           |
 | Tileset structure | asset // version                                                                                                      | "profile": "meshpyramids", // tileset type                                                                                |
 |                   | geometricError //                                                                                                     | "rootNode": "./nodes/root", // relative url                                                                               |

dev-docs/RFCs/v3.4/data-source-rfc.md

@@ -1,6 +1,7 @@
 # Data Sources API
 
-Build a data source API that can encompass services such 
+Build a data source API that can encompass services such
+
 - loaded data
 - URLS
 - tile service
@@ -12,13 +13,11 @@ Build a data source API that can encompass services such
 ### Related
 
 - deck.gl has a semi-internal data source API.
-- 
-
-
+-
 
 ## Main problems
 
-### Refresh / Dirty state handling. 
+### Refresh / Dirty state handling.
 
 How does the application (typically deck.gl)) know when to redraw?
 
@@ -36,6 +35,3 @@ Typing is a bit messy when overriding child class definitions.
 ## Declarative usage
 
 Fully declarative usage requires a lifecycle management system, which seems too heavy.
-
-
-

docs/arrowjs/README.md

@@ -28,13 +28,13 @@ Apache Arrow is emerging as the standard for large in-memory columnar data (Spar
 
 There are some excellent resources available that can help you quickly get a feel for what capabilities the Arrow JS API offers:
 
-* Observable: [Introduction to Apache Arrow](https://observablehq.com/@theneuralbit/introduction-to-apache-arrow)
-* Observable: [Using Apache Arrow JS with Large Datasets](https://observablehq.com/@randomfractals/apache-arrow)
-* Observable: [Manipulating Flat Arrays, Arrow-Style](https://observablehq.com/@lmeyerov/manipulating-flat-arrays-arrow-style)
-* [Manipulating Flat Arrays](https://observablehq.com/@mbostock/manipulating-flat-arrays) General article on Columnar Data and Data Frames
+- Observable: [Introduction to Apache Arrow](https://observablehq.com/@theneuralbit/introduction-to-apache-arrow)
+- Observable: [Using Apache Arrow JS with Large Datasets](https://observablehq.com/@randomfractals/apache-arrow)
+- Observable: [Manipulating Flat Arrays, Arrow-Style](https://observablehq.com/@lmeyerov/manipulating-flat-arrays-arrow-style)
+- [Manipulating Flat Arrays](https://observablehq.com/@mbostock/manipulating-flat-arrays) General article on Columnar Data and Data Frames
 
 Apache Arrow project links:
 
-* [Apache Arrow Home](https://arrow.apache.org/)
-* [Apache Arrow JS on github](https://github.com/apache/arrow/tree/master/js)
-* [Apache Arrow JS on npm](https://www.npmjs.com/package/apache-arrow)
+- [Apache Arrow Home](https://arrow.apache.org/)
+- [Apache Arrow JS on github](https://github.com/apache/arrow/tree/master/js)
+- [Apache Arrow JS on npm](https://www.npmjs.com/package/apache-arrow)