fix(tile-converter): skip failing content #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Aug 4, 2023
| @@ -147,6 +147,11 @@ export default class Tiles3DConverter { | |||
| if (sourceChild.contentUrl) { | |||
| const content = await loadI3SContent(this.sourceTileset, sourceChild, this.loaderOptions); | |||
|
|
|||
| if (!content) { | |||
| @@ -5,12 +5,13 @@ import {Matrix4, Vector3} from '@math.gl/core'; | |||
| import {Ellipsoid} from '@math.gl/geospatial'; | |||
| import {convertTextureAtlas} from './texture-atlas'; | |||
| import {generateSyntheticIndices} from '../../lib/utils/geometry-utils'; | |||
| import {I3STileContent} from '@loaders.gl/i3s'; | |||
| @@ -1,12 +1,14 @@ | |||
| import {TypedArray} from '@loaders.gl/loader-utils'; | |||
| export function convertTextureAtlas(texCoords: Float32Array, uvRegions: Uint16Array): Float32Array { | ||
| const convertedTexCoords = new Float32Array(texCoords.length); | ||
| export function convertTextureAtlas(texCoords: TypedArray, uvRegions: TypedArray): Float32Array { | ||
| const convertedTexCoords = new texCoords[Symbol.species](texCoords.length); |
There was a problem hiding this comment.
Hmm, I have never needed to use Symbol.species. Do we need this or can we get away with a simpler constructor. This feature seems to be for overriding default constructor when subclassing built in types? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/species.
Also do we still need the original texCoords after conversion? If not consider converting "in place" and avoid an allocation?
Finally an unrelated comment: In the algorithm below there are lots of little arrays being created for each iteration. I would recommend creating a few scratch arrays before the loop and reusing those, to reduce memory pressure and improve performance.
dsavinov-actionengine
added
the
ActionEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.