Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert parquet-wasm integration #2781

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Nov 9, 2023

Revert Parquet WASM integration due to overwhelming bundling issues.
For some reason the browser file replacement for the wasm loader wasn't taking effect and the node wasm still kept being imported. It could be a stupid typo, but running out of time to fight this and we need to cut a new release.

@ibgreen ibgreen marked this pull request as ready for review November 9, 2023 12:31
@ibgreen ibgreen requested a review from kylebarron November 9, 2023 12:31
@ibgreen ibgreen merged commit d3e1f0b into master Nov 9, 2023
3 of 4 checks passed
@ibgreen ibgreen deleted the ib/parquet-revert-wasm branch November 9, 2023 12:32
@kylebarron
Copy link
Collaborator

I haven't tried to export both of them at the same time. I use the node export in tests and the esm export in the browser, which have both worked well for me. (note, IIRC this uses the undocumented esm2 entry point, which removes import.meta.url, which I think was giving some sort of error previously in loaders)

@ibgreen
Copy link
Collaborator Author

ibgreen commented Nov 9, 2023

Any chance you could use a nestedexports field in package.json to export the appropriate version for browser&node and esm&commonjs? I think it would save a lot of grief in apps that try to use this.

https://webpack.js.org/guides/package-exports/#target-environment

You could also add explicit entry points for people who want to cherry-pick or use the experimental versions.

https://github.com/visgl/loaders.gl/blob/master/modules/parquet/package.json#L25

@kylebarron
Copy link
Collaborator

Can you try 0.6.0-beta.1 with kylebarron/parquet-wasm#382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants