chore(examples): Rewrite I3S BSL example with React FC #2885
Conversation
maxkuznetsov-actionengine
changed the title
|
Example is re-factored to get it based on react functional components. |
| color: black; | ||
| } | ||
| `; | ||
|
|
||
| export const Font = ` | ||
| font-family: 'Uber Move' sans-serif; |
There was a problem hiding this comment.
Nit: Move away from Uber fonts...
There was a problem hiding this comment.
Removed
| * We need to calculate projection of camera direction onto the ellipsoid surface. | ||
| * We use this projection as offset to add it to the tileset cartographic center position. | ||
| */ | ||
| const projection = zmin * Math.tan((pitch * Math.PI) / 180); |
There was a problem hiding this comment.
Nit: UPPER_CASE for constants.
There was a problem hiding this comment.
This logic came from old i3s example. Actually it's not needed here, so I've removed it.
| /** | ||
| * Shift longitude | ||
| */ | ||
| projectedPostion[0] += |
There was a problem hiding this comment.
If possible avoid relying on global side effects. Create a function that calculates the constant.
There was a problem hiding this comment.
This logic came from old i3s example. Actually it's not needed here, so I've removed it.
| } | ||
| }; | ||
|
|
||
| const renderSublayers = (sublayers: Sublayer[]) => { |
There was a problem hiding this comment.
Just as my preference, I prefer function syntax, at least for longer functions, so that is how most examples in this repo will look. But we don't necessarily need to be consistent
There was a problem hiding this comment.
Done
No description provided.