chore: Upgrade ocular-dev-tools to tsc+esbuild #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestions for testing local build:
|
Both these tests fail. Also WASM loading seems to fail in CI, but not locally. |
ibgreen
commented
Mar 6, 2024
ibgreen
commented
Mar 6, 2024
| @@ -44,8 +44,9 @@ | |||
| "fs": false | |||
| }, | |||
| "scripts": { | |||
| "pre-build": "npm run build-worker && npm run build-bundle && npm run build-bundle -- --env=dev && npm run build-triangulation-worker", | |||
| "build-bundle": "ocular-bundle ./src/index.ts", | |||
| "pre-build": "npm run build-worker && npm run build-bundle && npm run build-bundle-dev && npm run build-triangulation-worker", | |||
There was a problem hiding this comment.
Should this be prepublishOnly everywhere? Or good to stick with pre-build? Efficient, but a bit uncanny that some builds only happen on publish.
There was a problem hiding this comment.
Some packages require pre-build to run (copy of libs, build workers etc.)
Pessimistress
force-pushed
the
ib/bump-ocular
branch
from
7ac292f to
2d26c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade brings a massive 10x performance increase for our builds.
@belom88 @dsavinov-actionengine