chore(docs): Update i3s colorization tutorial #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Feb 28, 2024
| const stats: StatsInfo | null = (data?.stats as StatsInfo) || null; | ||
| ``` | ||
|
|
||
| ## Use @deck.gl-community/layers |
There was a problem hiding this comment.
Maybe the section should be called DataDrivenTile3DLayer - the fact that it is in the deck.gl-community repo/namespace is more of a detail?
If we reference this layer, does it have documentation in the deck.gl-community website that we can link to?
There was a problem hiding this comment.
You right, changed to DataDrivenTile3DLayer.
There is no documentation in the deck.gl-community for the layer.
|
|
||
| ```ts | ||
| function renderLayers() { | ||
| const loadOptions = {i3s: {coordinateSystem: COORDINATE_SYSTEM.LNGLAT_OFFSETS}}; |
There was a problem hiding this comment.
It might be worth adding comments explaining why this is necessary.
website/package.json
Outdated
| @@ -55,7 +55,7 @@ | |||
| "docusaurus-mdx-checker": "^3.0.0", | |||
| "docusaurus-node-polyfills": "^1.0.0", | |||
| "expr-eval": "^2.0.2", | |||
| "mapbox-gl": "npm:empty-npm-package@1.0.0", | |||
| "mapbox-gl": "^3.1.2", | |||
There was a problem hiding this comment.
We are trying to move away from mapbox.
There was a problem hiding this comment.
Reverted it back
belom88
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.