migration info loaders v4 #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Mar 7, 2024
| @@ -60,6 +60,7 @@ A major release that brings: | |||
| **@loaders.gl/csv** | |||
|
|
|||
| - New [`CSVWriter`](/docs/modules/csv/api-reference/csv-writer) allows export of tables in CSV format. | |||
| - Migration: The promise of parse() now returns `{ shape: string; data: [] }` instead of `[]`, so you should add `.data` to get the records. | |||
There was a problem hiding this comment.
We have an upgrade guide for this type of notes.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this belong in /core or /csv, as I've only tried the v4 parse() with the CSVLoader, but I found this to be a breaking change when updating from v3 -> v4 that wasn't mentioned in the release notes which i think belongs there somewhere.