Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update whats-new #2946

Merged
merged 5 commits into from
Apr 4, 2024
Merged

docs: update whats-new #2946

merged 5 commits into from
Apr 4, 2024

Conversation

belom88
Copy link
Collaborator

@belom88 belom88 commented Apr 4, 2024

No description provided.

@belom88 belom88 requested a review from ibgreen April 4, 2024 07:44
@@ -19,6 +20,8 @@ Target Release Date: April, 2024

**@loaders.gl/parquet**

- Support compression modes: 'zstd', 'snappy', 'gzip', 'brotli', 'no_compression'.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these were already supported? Certainly no_compression, gzip and snappy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember right now. Daria made fixes for few types of compressions.

@@ -19,6 +20,8 @@ Target Release Date: April, 2024

**@loaders.gl/parquet**

- Support compression modes: 'zstd', 'snappy', 'gzip', 'brotli', 'no_compression'.
- Geoparquet: support large 'Polygons' and 'MultiPolygons'. Up to 68159 vertices for 'MultiPolygon' and 20062 vertices for 'Polygon' has been tested.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a little odd to specify such numbers, it sounds like we don't understand what the limits in our implementation are.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Geoparquet: support large 'Polygons' and 'MultiPolygons' (> 10,000 vertices)"

Is this better?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, threshold was 65536 vertices (16 bit)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What confused me is that we reverted the Uint16 fix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You reverted but then you've fixed it back in #2940 . That was lucky change in another place )

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the reverted PR is not neede anymore

@ibgreen ibgreen merged commit 46d7f30 into master Apr 4, 2024
1 check passed
@ibgreen ibgreen deleted the vb/update-whats-new branch April 4, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants