-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update whats-new #2946
docs: update whats-new #2946
Conversation
@@ -19,6 +20,8 @@ Target Release Date: April, 2024 | |||
|
|||
**@loaders.gl/parquet** | |||
|
|||
- Support compression modes: 'zstd', 'snappy', 'gzip', 'brotli', 'no_compression'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these were already supported? Certainly no_compression, gzip and snappy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember right now. Daria made fixes for few types of compressions.
@@ -19,6 +20,8 @@ Target Release Date: April, 2024 | |||
|
|||
**@loaders.gl/parquet** | |||
|
|||
- Support compression modes: 'zstd', 'snappy', 'gzip', 'brotli', 'no_compression'. | |||
- Geoparquet: support large 'Polygons' and 'MultiPolygons'. Up to 68159 vertices for 'MultiPolygon' and 20062 vertices for 'Polygon' has been tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a little odd to specify such numbers, it sounds like we don't understand what the limits in our implementation are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Geoparquet: support large 'Polygons' and 'MultiPolygons' (> 10,000 vertices)"
Is this better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, threshold was 65536 vertices (16 bit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What confused me is that we reverted the Uint16 fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You reverted but then you've fixed it back in #2940 . That was lucky change in another place )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the reverted PR is not neede anymore
No description provided.