fix(plugin-vue): avoid throwing on never requested file

vitejs · Dec 29, 2020 · 48a24c1 · 48a24c1
1 parent ce4d714
commit 48a24c1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/packages/plugin-vue/src/handleHotUpdate.ts b/packages/plugin-vue/src/handleHotUpdate.ts
@@ -19,7 +19,7 @@ export async function handleHotUpdate(
   read: () => string | Promise<string>,
   server: ViteDevServer
 ): Promise<ModuleNode[] | void> {
-  const prevDescriptor = getDescriptor(file)
+  const prevDescriptor = getDescriptor(file, false)
   if (!prevDescriptor) {
     // file hasn't been requested yet (e.g. async component)
     return

diff --git a/packages/plugin-vue/src/index.ts b/packages/plugin-vue/src/index.ts
@@ -107,7 +107,7 @@ export default function vuePlugin(rawOptions: Options = {}): Plugin {
         if (query.src) {
           return fs.readFileSync(filename, 'utf-8')
         }
-        const descriptor = getDescriptor(filename)
+        const descriptor = getDescriptor(filename)!
         let block: SFCBlock | null | undefined
         if (query.type === 'script') {
           // handle <scrip> + <script setup> merge via compileScript()
@@ -139,7 +139,7 @@ export default function vuePlugin(rawOptions: Options = {}): Plugin {
         return transformMain(code, filename, options, this)
       } else {
         // sub block request
-        const descriptor = getDescriptor(filename)
+        const descriptor = getDescriptor(filename)!
         if (query.type === 'template') {
           return transformTemplateAsModule(code, descriptor, options, this)
         } else if (query.type === 'style') {

diff --git a/packages/plugin-vue/src/utils/descriptorCache.ts b/packages/plugin-vue/src/utils/descriptorCache.ts
@@ -34,14 +34,16 @@ export function setPrevDescriptor(filename: string, entry: SFCDescriptor) {
   prevCache.set(filename, entry)
 }
 
-export function getDescriptor(filename: string) {
+export function getDescriptor(filename: string, errorOnMissing = true) {
   if (cache.has(filename)) {
     return cache.get(filename)!
   }
-  throw new Error(
-    `${filename} has no corresponding SFC entry in the cache. ` +
-      `This is a @vitejs/plugin-vue internal error, please open an issue.`
-  )
+  if (errorOnMissing) {
+    throw new Error(
+      `${filename} has no corresponding SFC entry in the cache. ` +
+        `This is a @vitejs/plugin-vue internal error, please open an issue.`
+    )
+  }
 }
 
 export function setDescriptor(filename: string, entry: SFCDescriptor) {