feat: default esbuild jsxDev based on config.isProduction (#12386)

vitejs · Mar 13, 2023 · f24c2b0 · f24c2b0
1 parent b12f457
commit f24c2b0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -348,6 +348,7 @@ export type ResolvedConfig = Readonly<
       alias: Alias[]
     }
     plugins: readonly Plugin[]
+    esbuild: ESBuildOptions | false
     server: ResolvedServerOptions
     build: ResolvedBuildOptions
     preview: ResolvedPreviewOptions
@@ -657,6 +658,13 @@ export async function resolveConfig(
     mainConfig: null,
     isProduction,
     plugins: userPlugins,
+    esbuild:
+      config.esbuild === false
+        ? false
+        : {
+            jsxDev: !isProduction,
+            ...config.esbuild,
+          },
     server,
     build: resolvedBuildOptions,
     preview: resolvePreviewOptions(config.preview, server),

diff --git a/packages/vite/src/node/plugins/esbuild.ts b/packages/vite/src/node/plugins/esbuild.ts
@@ -209,7 +209,7 @@ export async function transformWithEsbuild(
   }
 }
 
-export function esbuildPlugin(options: ESBuildOptions = {}): Plugin {
+export function esbuildPlugin(options: ESBuildOptions): Plugin {
   const filter = createFilter(
     options.include || /\.(m?ts|[jt]sx)$/,
     options.exclude || /\.js$/,