Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prioritize existing env over .env (fixes #10676) #10684

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix: prioritize existing env over .env (fixes #10676) #10684

merged 1 commit into from
Oct 28, 2022

Conversation

sapphi-red
Copy link
Member

Description

#10113 inverted the logic and we forgot to move this part.

fixes #10676
refs #10113

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release labels Oct 28, 2022
@patak-dev patak-dev merged commit e2ea6af into vitejs:main Oct 28, 2022
@axelboc axelboc mentioned this pull request Oct 28, 2022
Closed
@sapphi-red sapphi-red deleted the fix/env-cli-override branch October 28, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vite 3.2 ignores env variables from cli
2 participants
@sapphi-red @patak-dev