chore: fix dev build replacing undefined #10740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug only happens with
pnpm dev
.pnpm dev
externalizes dependencies instead of bundling them.Here we are using the named export:
convertSourceMap.mapFileCommentRegex
.vite/packages/vite/src/node/server/transformRequest.ts
Line 5 in ee8c7a6
vite/packages/vite/src/node/server/transformRequest.ts
Line 201 in ee8c7a6
But because
convert-source-map
uses a uncommon notation, Node.js fails to detect this named export.As a result, in build, rollup achieves to handle this, and in dev,
convertSourceMap.mapFileCommentRegex
becomesundefined
.https://github.com/thlorenz/convert-source-map/blob/46c2b78aa56d25a77d3ea237051aeb5d9e7f750c/index.js#L11-L16
Then this line will be
.replace(undefined, blankReplacer)
and breaks@vite/client
.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).