Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(importGlob): preserve line count for sourcemap #11122

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix(importGlob): preserve line count for sourcemap #11122

merged 1 commit into from
Nov 29, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 29, 2022 •
edited
Loading

Description

sourcemap was broken when multiline import.meta.glob existed.

import.meta.glob(
  './*.js'
)

To check it out, add a console.log here.

vite/playground/glob-import/index.html

Line 64 in e92d025

useImports(nodeModules, '.result-node_modules')

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 29, 2022
@sapphi-red sapphi-red mentioned this pull request Nov 29, 2022
Merged
9 tasks
@patak-dev patak-dev merged commit 14980a1 into vitejs:main Nov 29, 2022
@sapphi-red sapphi-red deleted the fix/import-glob-sourcemap branch November 30, 2022 02:49
bluwy pushed a commit that referenced this pull request Dec 5, 2022
@sapphi-red @bluwy
fix(importGlob): preserve line count for sourcemap (#11122)
205c676
@bluwy bluwy mentioned this pull request Dec 5, 2022
Merged
patak-dev pushed a commit that referenced this pull request Dec 5, 2022
@bluwy @gtm-nayan
@julienv3 @sapphi-red
chore: cherry pick more v4 bug fixes to v3 (#11189)
eba9b42 
* fix: glob import parsing (#10949) (#11056)

closes #10949
closes #11051

* fix: import.meta.env and process.env undefined variable replacement (fix #8663) (#10958)

Co-authored-by: bluwy <bjornlu.dev@gmail.com>
fix #8663

* fix(esbuild): handle inline sourcemap option (#11120)

* fix(importGlob): preserve line count for sourcemap (#11122)

* fix: Dev SSR dep optimization + respect optimizeDeps.include (#11123)

* fix: reset global regex before match (#11132)

* chore: fix test

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: julienv3 <julienv3@gmail.com>
Co-authored-by: 翠 / green <green@sapphi.red>
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red @futurGH
fix(importGlob): preserve line count for sourcemap (vitejs#11122)
c3af1f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev