fix(resolve): ensure exports has precedence over mainFields #11234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p3-minor-bug
patak-dev
approved these changes
Dec 7, 2022
dominikg
added a commit
to dominikg/vite
that referenced
this pull request
Dec 8, 2022
…itejs#11234)" This reverts commit d6eb4f2.
patak-dev
pushed a commit
that referenced
this pull request
Dec 8, 2022
7 tasks
9 tasks
bluwy
added a commit
that referenced
this pull request
Jan 2, 2023
bluwy
added a commit
that referenced
this pull request
Jan 5, 2023
9 tasks
patak-dev
pushed a commit
that referenced
this pull request
Jan 5, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the exports field returns a file path that ends with
.mjs,mainFieldswill take precendence over it. This breaks how nodejs resolve and blocks svelte's node condition from being used.Additional context
Feels a bit late to push this, but I tried to make the smallest change possible to fix this bug specifically, which shouldn't break existing logic.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).