fix: await scanner #11242
Merged
fix: await scanner #11242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Dec 7, 2022
| @@ -202,7 +208,9 @@ async function createDepsOptimizer( | |||
| try { | |||
There was a problem hiding this comment.
Maybe we should wrap this callback and await that instead of just awaiting this part?
There was a problem hiding this comment.
I think the whole promise handling here is due a refactoring. Lets merge this this change that works so we can release a patch
|
Great finding! |
patak-dev
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When scanner didn't finish before server is closed, esbuild hanged up, I guess.
refs #11239
Additional context
What is the purpose of this pull request?