perf(build): disable rollup cache for builds #11454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrentz
added a commit
to danielrentz/rollup
that referenced
this pull request
Feb 15, 2023
Vite has changed the default of this option to "false" (vitejs/vite#11454), therefore it is needed to be able to set it to "true" explicitly. This may be useful in other situations too, e.g. extending some defaults options object which contains this option set to "false".
9 tasks
lukastaegert
added a commit
to rollup/rollup
that referenced
this pull request
Feb 16, 2023
* Allow to pass "true" to InputOptions.cache Vite has changed the default of this option to "false" (vitejs/vite#11454), therefore it is needed to be able to set it to "true" explicitly. This may be useful in other situations too, e.g. extending some defaults options object which contains this option set to "false". * adapt documentation of "cache" option * fix type error * Fix linting --------- Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com> Co-authored-by: Lukas Taegert-Atkinson <lukas.taegert-atkinson@tngtech.com>
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable rollup cache by default for building (non-watch) as we control the Rollup bundle and do not use the
.cacheoutput, which results in unused work. Settingcache: falseprevents Rollup from populating.cacheWhen/if rollup/rollup#4762 lands, it also enables memory perf improvements by default instead of needing the user to opt-in via
build.rollupOptions.cache: false. This should help #2433Additional context
Ran
buildand also updated the license.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).