Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vite does not
await
when callingbundle.close
which causes code expected to run after thecloseBundle
plugin hook to run before it insteadCloses vite-pwa/sveltekit#21
Additional context
A recent refactoring in SvelteKit caused this issue to be hit extremely frequently
Vite does do an
await
in the other location where it callsbundle.close
:vite/packages/vite/src/node/plugins/worker.ts
Line 132 in 5444781
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).