Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(legacy): correct modernPolyfills description #14233

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

sapphi-red
Copy link
Member

Description

modern chunks are used for "browsers that support widely-available features", not browsers with native ESM support.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added documentation Improvements or additions to documentation plugin: legacy labels Aug 29, 2023
@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit a57f388 into vitejs:main Aug 29, 2023
10 checks passed
@sapphi-red sapphi-red deleted the docs/legacy-modern-polyfills branch August 30, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants