Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await bundle close #2313

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix: await bundle close #2313

merged 1 commit into from
Mar 2, 2021

Conversation

hannoeru
Copy link
Contributor

@hannoeru hannoeru commented Feb 28, 2021 •
edited
Loading

Should await bundle.close() in build,
because some async rollup hooks will emit when bundle.close() called.

@antfu antfu added the bug label Feb 28, 2021
@yyx990803 yyx990803 merged commit c988574 into vitejs:main Mar 2, 2021
@hannoeru hannoeru deleted the fix/await-bundle-close branch March 2, 2021 16:23
This was referenced Mar 8, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannoeru @antfu @yyx990803