Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: srcset handling in html #6419

Merged
merged 13 commits into from
May 19, 2022
Merged

fix: srcset handling in html #6419

merged 13 commits into from
May 19, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jan 8, 2022 •
edited
Loading

Description

fix: #6418

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 marked this pull request as draft January 8, 2022 15:17
@poyoho poyoho marked this pull request as ready for review January 9, 2022 03:56
@poyoho poyoho added the inconsistency Inconsistency between dev & build label May 12, 2022
@poyoho poyoho removed needs rebase inconsistency Inconsistency between dev & build labels May 12, 2022
@poyoho poyoho closed this May 12, 2022
@poyoho poyoho deleted the fix/unexpect-metadata-url branch May 12, 2022 14:08
@poyoho poyoho restored the fix/unexpect-metadata-url branch May 12, 2022 14:54
@poyoho poyoho reopened this May 12, 2022
bluwy
bluwy approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC there are two things happening in this PR:

  1. Use config.base when rebasing file imports
  2. Handle replacements for srcset

But the changes seems fine to me

@patak-dev patak-dev changed the title fix(metadata): unexpect import.meta.url in serve fix: srcset handling in html May 19, 2022
@patak-dev patak-dev merged commit a0ee4ff into vitejs:main May 19, 2022
@poyoho poyoho deleted the fix/unexpect-metadata-url branch May 20, 2022 02:05
@bluwy bluwy mentioned this pull request Nov 19, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vite dev canonicalises paths incorrectly when base is specified
4 participants
@poyoho @patak-dev @bluwy @sapphi-red