You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's already possible to use vite from deno (import 'http://localhost:3000/src/main.jsx' for example). You only need to provide your own DOM & WebSocket impl but so far it works really great.
The only issue is that Deno thinks vite/client is TypeScript file (because it doesn't have .js suffix) and so it tries to do type-checking. It works with --no-check but I think there's no big reason why vite/client cannot have suffix (like other files in there) and play nice with others so I suggest adding it.
It should be very simple to fix (I have a PR already but it's failing and I'm not sure what's broken in there)
I did the change in my local node_modules and it worked fine so that's why I'm puzzled what's the issue.
System Info
requiredvite version: 1.0.0-rc.4
required Operating System: OSX
required Node version: node v12; deno 1.3.0
Err in CircleCI
The text was updated successfully, but these errors were encountered:
I'm not sure what this is trying to achieve and I have no idea why vite/client would need to be loaded in deno since it's a client-only file. This is also likely stale for 2.0. Either way, Vite currently has no plan for Deno support.
Description
It's already possible to use vite from deno (
import 'http://localhost:3000/src/main.jsx'
for example). You only need to provide your own DOM & WebSocket impl but so far it works really great.The only issue is that Deno thinks
vite/client
is TypeScript file (because it doesn't have.js
suffix) and so it tries to do type-checking. It works with--no-check
but I think there's no big reason whyvite/client
cannot have suffix (like other files in there) and play nice with others so I suggest adding it.It should be very simple to fix (I have a PR already but it's failing and I'm not sure what's broken in there)
I did the change in my local
node_modules
and it worked fine so that's why I'm puzzled what's the issue.System Info
vite
version: 1.0.0-rc.4Err in CircleCI
The text was updated successfully, but these errors were encountered: