fix(plugin-legacy): respect entryFileNames
for polyfill chunks
#8247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially breaking change:
vite/legacy-polyfills
in manifest is nowvite/legacy-polyfills-legacy
.polyfills-modern.hash.js
is nowpolyfills.hash.js
.Description
legacy and modern polyfill chunk file names now respect
entryFileNames
.As a byproduct, conflicted entry in manifest was solved. I will describe this in the additional context.
I tested with
pnpm build:custom-filename
inplayground/legacy
.close #4221
refs #8180
Additional context
When modernPolyfill is enabled,
vite/legacy-polyfills
inmanifest.json
points to modern polyfill chunk. Also there was no entry pointing to legacy polyfill chunk.When it is disabled, it points to legacy polyfill chunk.
It was like this.
This PR changes it to
What is the purpose of this pull request?
(maybe it's a feat than a fix?)
Before submitting the PR, please make sure you do the following
fixes #123
).