Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleaner default dev output #8638

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Jun 17, 2022

Description

Around ~2.4 we stopped exposing to the network by default. As this was a big change, we added a big Hint: note so people will know that they can still use --host to expose to the network

In v3, I think we can already clean up a bit the output and at least remove the bright Hint: label. We can still leave the message as it is dimmed and helpful

Before:

image

After (initial commit):

image

After (version after @bluwy's suggestions)

image


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jun 17, 2022
@bluwy
Copy link
Member

bluwy commented Jun 17, 2022

Perhaps we can remove the too? Otherwise it feels a bit off for me.

I also kinda like that we have the Network: label as before too, if that's an option 😄

@patak-dev
Copy link
Member Author

patak-dev commented Jun 17, 2022

@bluwy how it looks with other options

  1. No bullet point

image

  1. Hint -> Network

image

  1. Network dimmed

image

  1. Network dimmed, simplify message

image

  1. same as 5, using arrow caret

image

I like 6 the most

@patak-dev
Copy link
Member Author

patak-dev commented Jun 17, 2022

Even better with the arrow being dimmed green (this is what is currently implemented in the PR):
image

@bluwy
Copy link
Member

bluwy commented Jun 17, 2022

Nicee! I like no6 too.

@patak-dev patak-dev merged commit dbd9688 into main Jun 18, 2022
@patak-dev patak-dev deleted the feat/cleaner-default-dev-output branch June 18, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants