refactor(resolve): remove commonjs plugin handling

[sagargurtu]

Description

This PR fixes the commonjs HELPERS_ID (reference link) in resolve plugin.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[sapphi-red]

In fact, after #8743, this condition was never met because commonjs plugin is always the first one.
https://github.com/rollup/plugins/blob/add3a350e99505e15790b4915c33b1fcc5bf00ec/packages/commonjs/src/index.js#L186-L199

Maybe we could simply remove this condition?

[sagargurtu]

I'm not sure. I don't have much knowledge of the codebase but could a custom plugin change the ordering of internal plugins by implementing the options hook? If yes, then, you might still need to keep this condition. Or do you not care about what custom plugins do?

[bluwy]

Interesting find @sapphi-red. I'd also prefer if we remove this condition instead since it won't be called. I don't think there will be a custom plugin that would sort Vite's resolve plugin to first, that would break many things.

[patak-dev]

@bluwy @sapphi-red this looks safe to me for a patch, would you approve if you think the same? Also, interesting to see rollup injecting plugins in options in this way.

[sapphi-red]

FYI This reordering behavior was introduced in plugin-commonjs v22.0.0. The reason is described here.