Type '{ strictRequires: string[]; }' is not assignable to type 'RollupCommonJSOptions'. Object literal may only specify known properties, and 'strictRequires' does not exist in type 'RollupCommonJSOptions'.

[brendon]

Description

I'd like to use the new stringRequires feature outlined here: https://github.com/rollup/plugins/tree/master/packages/commonjs#strictrequires

I get a TypeScript warning (per the subject line). I assume that the compiled version of @rollup/plugin-commonjs isn't 22.x that is when stringRequires was added.

The dev dependency is specified as "@rollup/plugin-commonjs": "^22.0.1",. But perhaps the build is happening on an older version?

Suggested solution

I assume vite would just need to be built against this newer version of @rollup/plugin-commonjs?

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[brendon]

Here are the lines from the latest types:

https://github.com/rollup/plugins/blob/add3a350e99505e15790b4915c33b1fcc5bf00ec/packages/commonjs/types/index.d.ts#L100-L105

[brendon]

I'll leave this open in case someone thinks it's a good idea, but I did end up finding more documentation in the Vite 3 release notes about how to just use esbuild in production (before Vite 4). Since I did all the work to get my javascript working with esbuild in development, it made sense to just use this build tool in production too. I'm glad that's becoming the default in the future as to be honest, it caused me so much confusion when trying to convert from webpack.