Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): skip resolve builtin modules #10420

Merged
merged 3 commits into from
Oct 12, 2022
Merged

fix(config): skip resolve builtin modules #10420

merged 3 commits into from
Oct 12, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 11, 2022

Description

Fix #10410
Fix #10365
Regression from #10254

Don't resolve path for builtin nodejs modules and let nodejs resolve itself

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Oct 11, 2022
@bluwy bluwy merged commit ecba3f8 into main Oct 12, 2022
@bluwy bluwy deleted the fix-nodejs-module-config branch October 12, 2022 10:24
bluwy added a commit that referenced this pull request Oct 13, 2022
@bluwy
fix(config): skip resolve builtin modules (#10420)
e75a472
@bluwy bluwy mentioned this pull request Oct 13, 2022
Merged
patak-dev pushed a commit that referenced this pull request Oct 13, 2022
@bluwy
fix(config): support builtin modules and deno (#10457)
8fbae69 
* fix(config): skip resolve builtin modules (#10420)

* fix(config): partial deno support (#10446)
This was referenced Oct 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: import_url.URL is not a constructor build fails with import statement in 3.1.6
2 participants
@bluwy @antfu