Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): #10424 #10432

Closed
wants to merge 1 commit into from
Closed

fix(cli): #10424 #10432

wants to merge 1 commit into from

Conversation

ilteoood
Copy link

Description

fix #10424

Additional context

Fixed CLI module which parses the --host option.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ilteoood ilteoood changed the title fix #10424 fix: #10424 Oct 11, 2022
@ilteoood ilteoood changed the title fix: #10424 fix(cli): #10424 Oct 11, 2022
@sapphi-red
Copy link
Member

This seems to be solving the same thing with #10474.
I'm closing this as #10474 does more things, but would you comment to that PR if you find anything there? Thanks!

@sapphi-red sapphi-red closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite Local address is badly formatted when using multiple --host
2 participants