fix(ssr): skip optional peer dep resolve #10593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #10255
Skip optional peer dep resolve when running the vite resolver through
hookNodeResolve
.From the issue, technically it's impossible to have the optional peer dep resolved via
hookNodeResolve
, but there is a race condition that makes this happen that I can't minimize as a test case.Additional context
I can't seem to replicate the test locally, so no tests added, but it is consistently reproducible with the issue repro.
I think we should remove
hookNodeResolve
in Vite 4. It has caused a lot of inconsistencies and bugs with features only working in CJS (which we're phasing out). I can try to attempt this in another PR.I'd also like to backport this to v3
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).