fix(ssr): improve missing file error #10880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #10002
When we can't read a file from the fs,
transformRequest
wouldreturn null
, hiding the error.This PR throws the error instead, with an error code to handle an edge case explained below. This would print a descriptive error when a file is missing instead.
Additional context
Partially reverts c30f6d7
The server transform middleware uses
transformRequest
, but for invalid urls, it needs to skip and let other middlewares handle instead. Skipping is now done by checking for the error codeERR_LOAD_URL
.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).