feat(ssr)!: remove dedupe and mode support for CJS #11101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reverts #3951
Remove
hookNodeResolve
and thessrRequireHook
plugin so there isn't a chance for Vite's custom node resolver to interfere in cases we don't want to. Followup to #10593Additional context
I've hit this issue again at withastro/astro#5459, it would be nice to remove this in Vite 4.
We don't have tests that cover this feature.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).