Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add example for mergeConfig with a config in callback form #14144

Merged
merged 1 commit into from
Aug 18, 2023
Merged

docs: add example for mergeConfig with a config in callback form #14144

merged 1 commit into from
Aug 18, 2023

Conversation

vinassefranche
Copy link
Contributor

@vinassefranche vinassefranche commented Aug 17, 2023 •
edited
Loading

Description

As discussed in this closed issue, this is something that is nice to tell the users that browser the documentation.
Here's the result:
image

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vinassefranche vinassefranche mentioned this pull request Aug 17, 2023
Closed
7 tasks
@vinassefranche vinassefranche changed the title Add example for mergeConfig with a config in callback form doc: add example for mergeConfig with a config in callback form Aug 17, 2023
@vinassefranche vinassefranche changed the title doc: add example for mergeConfig with a config in callback form docs: add example for mergeConfig with a config in callback form Aug 17, 2023
@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Aug 18, 2023
@sapphi-red sapphi-red merged commit 094b732 into vitejs:main Aug 18, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinassefranche @patak-dev @sapphi-red